Bump java to 21 #1014
Merged
Bump java to 21 #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Jul 9, 2024
| @@ -24,6 +22,9 @@ jobs: | |||
| # need to switch to root so that github actions can install runner binary on container without permission issues. | |||
| options: --user root | |||
|
|
|||
| env: | |||
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true | |||
There was a problem hiding this comment.
It is an issue with github runners:
On June 30th 2024, we will change the default from Node16 to Node20.
To opt out of this and continue using Node16 while it is still available in the runner, you can choose to set ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true
Swiddis
approved these changes
Jul 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit b24ed48) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2024
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit b24ed48) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq
pushed a commit
that referenced
this pull request
Jul 22, 2024
(cherry picked from commit b24ed48) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rupal-bq
pushed a commit
that referenced
this pull request
Jul 22, 2024
(cherry picked from commit b24ed48) Signed-off-by: Derek Ho <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump java to 21. Adds unsecure node env to prevent build failures.
Issues Resolved
Fix: #1002
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.